Skip to content

Conversation

@lentzi90
Copy link
Contributor

What this PR does / why we need it:

This enables the UseKindForManagementCluster flag for all clusterctl upgrade tests, which makes them use a kind cluster as the secondary management cluster instead of creating an OpenStack workload cluster.

This significantly reduces the resource requirements for these tests by using lightweight kind containers instead of full VMs, and it also speeds up the test execution.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2098

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2025
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit e7c1b8d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68f76013e58b380008db6944
😎 Deploy Preview https://deploy-preview-2792--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This enables the UseKindForManagementCluster flag for all clusterctl
upgrade tests, which makes them use a kind cluster as the secondary
management cluster instead of creating an OpenStack workload cluster.

This significantly reduces the resource requirements for these tests
by using lightweight kind containers instead of full VMs, and it also
speeds up the test execution.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/docker-cluster branch from 61c9385 to e7c1b8d Compare October 21, 2025 10:27
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor Author

Looks like it works, and saves a few minutes for the test also!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 21, 2025

There is a bit of cleanup we could do after this also, but let's take it separately in case we want to revert for some reason.
The things we can cleanup is this:

These are used to upload the CAPO image that is being tested into the management cluster. All other tests use kind clusters where the image is loaded directly, but the clusterctl upgrade was using a full CAPO cluster so we used this to get the image into it.

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

1 similar comment
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2025
@lentzi90
Copy link
Contributor Author

/approve
This is ready to take in

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2025
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9128301 into kubernetes-sigs:main Oct 24, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 24, 2025
@lentzi90 lentzi90 deleted the lentzi90/docker-cluster branch October 24, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

E2E: Use kind cluster for clusterctl upgrade tests

4 participants